Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix crashes caused by typevarlikes defaults in-place modifications #20139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilevkivskyi merged 5 commits into from
Nov 20, 2025
Merged

Fix crashes caused by typevarlikes defaults in-place modifications #20139

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6e08879
Prohibit typevars defaulting to something out of scope
sterliakov Oct 28, 2025
dd867a4
Refactor to pass fail func to bind_new instead
sterliakov Oct 30, 2025
388fafe
Merge remote-tracking branch 'upstream/master' into bugfix/gh-19186-t…
sterliakov Oct 30, 2025
d0760b1
Merge remote-tracking branch 'upstream/master' into bugfix/gh-19186-t…
ilevkivskyi Nov 20, 2025
cabdf50
Some more testing
ilevkivskyi Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Some more testing
  • Loading branch information
@ilevkivskyi
ilevkivskyi committed Nov 20, 2025
commit cabdf50033df4e9fec9e2d3656ed6f59f071dde9
20 changes: 17 additions & 3 deletions test-data/unit/check-typevar-defaults.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ T3 = TypeVar("T3", bound=List[Any], default=List[int])
T4 = TypeVar("T4", int, str, default=int)
T5 = TypeVar("T5", default=S0)
T6 = TypeVar("T6", bound=float, default=S1)
# T7 = TypeVar("T7", bound=List[Any], default=List[S0]) # TODO
T7 = TypeVar("T7", bound=List[Any], default=List[S0])

P1 = ParamSpec("P1", default=[])
P2 = ParamSpec("P2", default=...)
Expand All @@ -50,7 +50,7 @@ P4 = ParamSpec("P4", default=P0)

Ts1 = TypeVarTuple("Ts1", default=Unpack[Tuple[int]])
Ts2 = TypeVarTuple("Ts2", default=Unpack[Tuple[int, ...]])
# Ts3 = TypeVarTuple("Ts3", default=Unpack[Ts0]) # TODO
Ts3 = TypeVarTuple("Ts3", default=Unpack[Ts0])
[builtins fixtures/tuple.pyi]

[case testTypeVarDefaultsInvalid]
Expand Down Expand Up @@ -180,7 +180,7 @@ reveal_type(func_b1(callback1)) # N: Revealed type is "def (x: builtins.str)"
reveal_type(func_b1(2)) # N: Revealed type is "def (builtins.int, builtins.str)"

def func_c1(x: Union[int, Callable[[Unpack[Ts1]], None]]) -> Tuple[Unpack[Ts1]]: ...
# reveal_type(func_c1(callback1)) # Revealed type is "Tuple[str]" # TODO
reveal_type(func_c1(callback1)) # N: Revealed type is "tuple[builtins.str]"
reveal_type(func_c1(2)) # N: Revealed type is "tuple[builtins.int, builtins.str]"
[builtins fixtures/tuple.pyi]

Expand Down Expand Up @@ -894,6 +894,20 @@ Alias: TypeAlias = "MyClass[T1, T2]"
class MyClass(Generic["T1", "T2"]): ...
[builtins fixtures/tuple.pyi]

[case testDefaultsApplicationInAliasNoCrashNested]
from typing import Generic, TypeVar
from typing_extensions import TypeAlias

T1 = TypeVar("T1")
T2 = TypeVar("T2", default=list[T1])

Alias: TypeAlias = "MyClass[T1, T2]"

class MyClass(Generic["T1", "T2"]): ...
x: Alias[int]
reveal_type(x) # N: Revealed type is "__main__.MyClass[builtins.int, builtins.list[builtins.int]]"
[builtins fixtures/tuple.pyi]

[case testDefaultsMustBeInScope]
from typing import Generic, TypeVar

Expand Down