Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix crash with tuple unpack inside TypeVar default #20456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilevkivskyi merged 2 commits into from
Dec 23, 2025
Merged

Fix crash with tuple unpack inside TypeVar default #20456

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
905e7ab
Fix crash with tuple unpack inside TypeVar default
cdce8p Dec 22, 2025
976e57f
Fix MixedTraverserVisitor instead
cdce8p Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix MixedTraverserVisitor instead
  • Loading branch information
@cdce8p
cdce8p committed Dec 23, 2025
commit 976e57f9f5e2f8be0672bc3604fa26924d6d3d8a
1 change: 1 addition & 0 deletions mypy/mixedtraverser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ def visit_type_alias_expr(self, o: TypeAliasExpr, /) -> None:
def visit_type_var_expr(self, o: TypeVarExpr, /) -> None:
super().visit_type_var_expr(o)
o.upper_bound.accept(self)
o.default.accept(self)
for value in o.values:
value.accept(self)

Expand Down
2 changes: 0 additions & 2 deletions mypy/typeops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,6 @@ def tuple_fallback(typ: TupleType) -> Instance:
and unpacked_type.type.fullname == "builtins.tuple"
):
items.append(unpacked_type.args[0])
elif isinstance(unpacked_type, TupleType):
items.extend(unpacked_type.items)
else:
raise NotImplementedError
else:
Expand Down