Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix fine-grained deps in diff-cache.py tool + add test #20837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JukkaL merged 10 commits into from
Feb 17, 2026
Merged

Fix fine-grained deps in diff-cache.py tool + add test #20837

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
09be294
Fix dependency calculation in diff-cache.py tool
JukkaL Feb 17, 2026
be856fa
WIP add test
JukkaL Feb 17, 2026
084a7cc
Update test
JukkaL Feb 17, 2026
f725336
Use sqlite cache
JukkaL Feb 17, 2026
79c5e38
Also test deps
JukkaL Feb 17, 2026
04a33fc
Test apply cache diff
JukkaL Feb 17, 2026
d2a5fb0
Lint
JukkaL Feb 17, 2026
366c6c1
Update comments and docstrings
JukkaL Feb 17, 2026
2010b3f
The new test suite should treated as a slow one
JukkaL Feb 17, 2026
a8e10e5
Fix PYTHONPATH
JukkaL Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix dependency calculation in diff-cache.py tool 
The diff was calculated the wrong way around.
  • Loading branch information
@JukkaL
JukkaL committed Feb 17, 2026
commit 09be2947d3a7bfe9d4c451b05c31fb9f658fd7ed
8 changes: 4 additions & 4 deletions misc/diff-cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,9 @@ def main() -> None:
parser = argparse.ArgumentParser()
parser.add_argument("--verbose", action="store_true", default=False, help="Increase verbosity")
parser.add_argument("--sqlite", action="store_true", default=False, help="Use a sqlite cache")
parser.add_argument("input_dir1", help="Input directory for the cache")
parser.add_argument("input_dir2", help="Input directory for the cache")
parser.add_argument("output", help="Output file")
parser.add_argument("input_dir1", help="Input directory for the original cache")
parser.add_argument("input_dir2", help="Input directory for the target cache")
parser.add_argument("output", help="Output file with the diff from original cache")
args = parser.parse_args()

cache1 = make_cache(args.input_dir1, args.sqlite)
Expand Down Expand Up @@ -199,7 +199,7 @@ def main() -> None:

# Compute what deps have been added and merge them all into the
# @root deps file.
new_deps = {k: deps1.get(k, set()) - deps2.get(k, set()) for k in deps2}
new_deps = {k: deps2.get(k, set()) - deps1.get(k, set()) for k in deps2}
new_deps = {k: v for k, v in new_deps.items() if v}
try:
root_deps = load(cache1, "@root.deps.json")
Expand Down