Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[mypyc] Do not preemptively diff & union op level dataflow sets #20897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hauntsaninja merged 9 commits into from
Feb 26, 2026
Merged

[mypyc] Do not preemptively diff & union op level dataflow sets #20897

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3aed3b2
Fix: Do not preemptively diff & union op level dataflow sets
VaggelisD Feb 25, 2026
e90a04d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 25, 2026
0bb52f6
Do the same for block-level dataflow too
VaggelisD Feb 25, 2026
9e0bfc9
Do not copy for block-level dataflow, cache empty set creation
VaggelisD Feb 25, 2026
3492914
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 25, 2026
6208e4f
Fix CI from EMPTY
VaggelisD Feb 25, 2026
5b6c1ac
Use frozenset for EMPTY
VaggelisD Feb 25, 2026
4ce4c07
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 25, 2026
43799d3
Merge branch 'master' into dataflow_cur
hauntsaninja Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use frozenset for EMPTY
  • Loading branch information
@VaggelisD
VaggelisD committed Feb 25, 2026
commit 5b6c1acef1f2b52af916f6fec32ee4478ef58e4b
6 changes: 3 additions & 3 deletions mypyc/analysis/dataflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from __future__ import annotations

from abc import abstractmethod
from collections.abc import Iterable, Iterator
from collections.abc import Iterable, Iterator, Set as AbstractSet
from typing import Any, Generic, TypeVar

from mypyc.ir.ops import (
Expand Down Expand Up @@ -174,9 +174,9 @@ def __str__(self) -> str:
return f"before: {self.before}\nafter: {self.after}\n"


GenAndKill = tuple[set[T], set[T]]
GenAndKill = tuple[AbstractSet[T], AbstractSet[T]]

_EMPTY: GenAndKill[Any] = (set(), set())
_EMPTY: tuple[frozenset[Any], frozenset[Any]] = (frozenset(), frozenset())


class BaseAnalysisVisitor(OpVisitor[GenAndKill[T]]):
Expand Down
4 changes: 3 additions & 1 deletion mypyc/analysis/selfleaks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,9 @@
)
from mypyc.ir.rtypes import RInstance

GenAndKill = tuple[set[None], set[None]]
from mypyc.analysis.dataflow import GenAndKill as _DataflowGenAndKill

GenAndKill = _DataflowGenAndKill[None]

CLEAN: GenAndKill = (set(), set())
DIRTY: GenAndKill = ({None}, {None})
Expand Down
Loading