-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[mypyc] Fix lambda inside comprehension #21009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
p-sawicki
merged 4 commits into
python:master
from
VaggelisD:fix-lambda-in-comprehension
Mar 18, 2026
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
8085088
[mypyc] Fix lambda inside comprehension failing to capture loop varia…
VaggelisD b3e22f3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] dedeba6
Fix comprehension scope not inheriting enclosing function's symtable
VaggelisD e86091b
Add lambda comprehension tests with different parameter names
VaggelisD File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix comprehension scope not inheriting enclosing function's symtable
When a comprehension with a lambda creates a synthetic scope via enter_scope(), the new scope got an empty symtable. This meant variables from the enclosing function (e.g. parameters used as the comprehension's iterable) were not accessible, causing UnboundLocalError at runtime. Fix by copying the parent symtable into the comprehension scope. Since the comprehension is inlined (same basic blocks and registers), the parent's register references remain valid.
- Loading branch information
commit dedeba66bb666dd1e21709627e2df389cd6f4f79
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also add test where the name is different, e.g.
lambda n=i: n * 2(here and below)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done