Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make it so that error comments in tests are not ignored if they occur at the beginning of a line #21172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wyattscarpenter wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Make it so that error comments in tests are not ignored if they occur at the beginning of a line #21172

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
87b76e7
add succeeding test and failing test relevant to feature
wyattscarpenter Apr 5, 2026
33e732b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 5, 2026
1ed3f49
fix the issue
wyattscarpenter Apr 5, 2026
b2c0044
Merge branch 'master' into error_message_leading_line
wyattscarpenter Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add succeeding test and failing test relevant to feature
  • Loading branch information
@wyattscarpenter
wyattscarpenter committed Apr 5, 2026
commit 87b76e721944b0310e0153090426c2f1726bae9c
23 changes: 23 additions & 0 deletions mypy/test/meta/test_parse_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,3 +67,26 @@ def test_bad_eq_version_check(self) -> None:
assert (
"version==3.7 always false since minimum runtime version is (3, 10)" in actual.stdout
)

def test_typical_error_comment(self) -> None:
# Act
actual = _run_pytest("""
[case abc]
a # E: typical-looking error comment
""")

# Assert
assert (
"typical-looking error comment" in actual.stderr
)
def test_lineleading_error_comment(self) -> None:
# Act
actual = _run_pytest("""
[case abc]
# E: line-leading error comment
""")

# Assert
assert (
"line-leading error comment" in actual.stderr
)
Loading