Re-introduce GC freeze hack into parallel checking#21302
Open
ilevkivskyi wants to merge 1 commit intopython:masterfrom
Open
Re-introduce GC freeze hack into parallel checking#21302ilevkivskyi wants to merge 1 commit intopython:masterfrom
ilevkivskyi wants to merge 1 commit intopython:masterfrom
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Collaborator
|
I can try this out tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives around 4-5% speed improvement on self-check while I don't see any visible change in memory use. I also process implementations one by one, this should allow freeing some memory a bit earlier, while I don't think this will have any effect on cache writing performance.
@JukkaL could you please run this on Dropbox code bases, while checking the memory use as well (preferably on both Mac and Linux)?