Thanks to visit codestin.com
Credit goes to github.com

Skip to content

A hot fix for crash in internal repos #4927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2018
Merged

A hot fix for crash in internal repos #4927

merged 2 commits into from
Apr 18, 2018

Conversation

ilevkivskyi
Copy link
Member

No description provided.

@ilevkivskyi ilevkivskyi requested a review from JukkaL April 18, 2018 13:30
JukkaL
JukkaL reviewed Apr 18, 2018
View reviewed changes
mypy/fixup.py Outdated
# Not yet: assert '.' in head, "Cannot find %s" % (name,)
stale = stale_info(modules)
stale.fallback_to_any = True
return stale
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should return a SymbolTableNode, not TypeInfo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, indeed. Will fix

JukkaL
JukkaL approved these changes Apr 18, 2018
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge if the build passes.

@ilevkivskyi ilevkivskyi merged commit 025e3de into python:master Apr 18, 2018
@ilevkivskyi ilevkivskyi deleted the hot-fix branch April 18, 2018 13:47
msullivan added a commit that referenced this pull request Apr 18, 2018
@msullivan
Revert "A hot fix for crash in internal repos (#4927)"
524fdcd 
This reverts commit 025e3de.
@msullivan msullivan mentioned this pull request Apr 18, 2018
Merged
msullivan added a commit that referenced this pull request Apr 24, 2018
@msullivan
Revert "A hot fix for crash in internal repos (#4927)"
f4916de 
This reverts commit 025e3de.
JukkaL pushed a commit that referenced this pull request Apr 26, 2018
@msullivan @JukkaL
Compute mangled fullnames properly for nested classes inside functions (
615fca4 
#4931)

This reverts #4927 and fixes the (a?) bug that it was working around.

Previously, mangled local fullnames were only computed if the class was directly inside a function, and not for nested classes inside a function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilevkivskyi @JukkaL