Use new semantic analyzer for bootstrap #6966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, now that the mypyc build indeed failed, I will move the pin. |
msullivan
approved these changes
Jun 10, 2019
OK, lets do this! |
PattenR
pushed a commit
to PattenR/mypy
that referenced
this pull request
Jun 23, 2019
This also updates mypyc pin to the latest version that works well with new analyzer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure we should do this right now. But maybe it is at least we should use it for mypy CI build (because e.g. making this work required couple small updates in mypyc)?
(IIUC, this should initially fail, until I update the mypyc pin.)