Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[mypyc] Merge int ops(for int_rprimitive) to CallC #9019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 18, 2020
Merged

[mypyc] Merge int ops(for int_rprimitive) to CallC #9019

merged 5 commits into from
Jun 18, 2020

Conversation

@TH3CHARLie
Copy link
Collaborator

@TH3CHARLie TH3CHARLie commented Jun 18, 2020

related mypyc/mypyc#734

int_compare_op of short_int_rprimitive remain changed because they'll need some low-level arithmetic.

JukkaL
JukkaL approved these changes Jun 18, 2020
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Integer comparison ops will need a different approach eventually, since they use inline functions, but it can wait until later. Inline functions are fine with the C back end.

@JukkaL JukkaL merged commit be01236 into python:master Jun 18, 2020
@TH3CHARLie TH3CHARLie deleted the merge-int-ops branch June 20, 2020 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TH3CHARLie @JukkaL