[mypyc] Add primitives for bitwise ops - #9529
Merged
Merged
Conversation
These used to be significantly slower than CPython.
It's only partially optimized.
Collaborator
Author
|
Hmm I'm going to have to specialize some of the ops for booleans as well, as otherwise the integer ops will be used, resulting in runtime type errors. |
TH3CHARLie
approved these changes
Oct 5, 2020
TH3CHARLie
left a comment
Collaborator
There was a problem hiding this comment.
Overall LGTM and that's a great improvement!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds primitives for
&,|,^,<<,>>and~. These speed up abitwise op microbenchmark by about 10x on Linux.
Long integer operations are only slightly faster, except for certain cases
of mixed short/long integers, where we are significantly faster (but only
maybe 1.5x or so).
Also support
boolwhen relevant, since it's a subclass ofintandoverrides some operations.
Work on mypyc/mypyc#751.