[mypyc] optimise startswith and endswith - #9557
Conversation
There was a problem hiding this comment.
LGTM and thanks for adding more primitives to mypyc!
@JukkaL Do you think is it worth to implement these two ops directly in the irbuild?(I've checked and it's possible to do so)
|
@TH3CHARLie Except for the most performance critical primitives it's better to use a wrapper function, since they are easier to write and maintain. If these turn out to be bottlenecks in some (realistic) benchmarks, we can consider implementing these in irbuild. |
|
I checked that this improves the The results should automatically update overnight here so we can see how it performs on the benchmarks server: https://github.com/mypyc/mypyc-benchmark-results/blob/master/reports/summary-microbenchmarks.md |
Description
Relates to mypyc/mypyc#644
Test Plan
Includes unit test