[mypyc] Make multiple assignment faster(1st stage) - #9575
Merged
Conversation
Collaborator
Author
|
Some imprecise benchmark results: Before: After: |
Collaborator
Author
|
I believe the failed |
JukkaL
approved these changes
Oct 14, 2020
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Looks great! This fixes a bad performance bottleneck.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates mypyc/mypyc#729
This PR makes simple cases like
y, x = x, yfaster.I tend to do some future improvement based on this PR(for example, supporting
ListExpras @JukkaL suggested), nevertheless, this PR itself should cover the most frequent use case.