[mypyc] Implement str-to-float primitive - #9685
Merged
Merged
Conversation
Collaborator
Author
|
before: after: |
Amir436
approved these changes
Nov 1, 2020
JukkaL
approved these changes
Nov 2, 2020
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
A nice perf win!
Can you also add a test case for this? For example, create mypyc/test-data/run-floats.test, or add to mypyc/test-data/run-misc.test?
Collaborator
Author
Sure, I'll merge this once the testcase is added and CI gets green |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related mypyc/mypyc#644
Implement
builtins.floatconversion from strings.