Fix false unreachable error reports. - #9909
Merged
Merged
Conversation
So far, method `TypeChecker.intersect_instances` generally reports an unreachable error for statements like `isinstance(a, B)` when `class C(A, B)` is unsafe without checking if `class C(B, A)` could be safe. This commit solves this by performing the "reversed" check only if the usual one fails. Hence, other functionalities and performance should not be affected. The new test case `testIsInstanceAdHocIntersectionReversed` demonstrates the new functionality. Note that this commit changes the type of argument `instances`. It is now `Tuple[Instance, Instance]` instead of `Sequence[Instance]`. Supporting an arbitrary number of `Instance` objects would require stronger code modifications.
JelleZijlstra
approved these changes
May 16, 2021
JelleZijlstra
left a comment
Member
There was a problem hiding this comment.
Looks good but I'd also want @JukkaL to review this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9907
For explanations, please see the commit message.
I hope changing the signature of method
TypeChecker.intersect_instancesis acceptable.