Thanks to visit codestin.com
Credit goes to github.com

Skip to content

PEP 1: Relax CODEOWNERS rule to allow PEP editors to "own" PEPs #2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 20, 2022
Merged

PEP 1: Relax CODEOWNERS rule to allow PEP editors to "own" PEPs #2252

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
22b0731
Relax CODEOWNERS rule to allow PEP editors to "own" PEPs
AA-Turner Jan 20, 2022
fe48157
fix spacing
AA-Turner Jan 20, 2022
c04eab6
Standardise access wording
AA-Turner Jan 20, 2022
5fa4f99
Standardise access wording redux
AA-Turner Jan 20, 2022
50ba35e
Don't use such that twice
AA-Turner Jan 20, 2022
8e7bd51
Wording update
CAM-Gerlach Jan 20, 2022
d5c3645
Plural agreement
AA-Turner Jan 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions pep-0001.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,9 +188,10 @@ The standard PEP workflow is:
"Informational", or "Process" as appropriate, and for the "Status:"
field enter "Draft". For full details, see `PEP Header Preamble`_.

* Update `.github/CODEOWNERS` [7]_ such that any core developer co-author(s) or
sponsor are listed for your new file such that any future pull requests will
be assigned to them.
* Update `.github/CODEOWNERS` [7]_ such that any co-author(s) or sponsors
with write access to the `PEP repository`_ are listed for your new file.
This ensures any future pull requests changing the file will be assigned
to them.

* Push this to your GitHub fork and submit a pull request.

Expand Down Expand Up @@ -229,7 +230,7 @@ not providing proper motivation or addressing backwards compatibility, or not
in keeping with the Python philosophy. The Steering Council can be consulted
during the approval phase, and are the final arbiter of a draft's PEP-ability.

Developers with git push privileges for the `PEP repository`_ may claim PEP
Developers with write access to the `PEP repository`_ may claim PEP
numbers directly by creating and committing a new PEP. When doing so, the
developer must handle the tasks that would normally be taken care of by the
PEP editors (see `PEP Editor Responsibilities & Workflow`_). This includes
Expand All @@ -240,7 +241,7 @@ if you need assistance from PEP editors, mention ``@python/pep-editors``
on GitHub.

As updates are necessary, the PEP author can check in new versions if they
(or a collaborating developer) have git push privileges.
(or a collaborating developer) have write access to the `PEP repository`_.

After a PEP number has been assigned, a draft PEP may be discussed further on
python-ideas (getting a PEP number assigned early can be useful for ease of
Expand Down Expand Up @@ -642,7 +643,7 @@ your changes don't get lost.
When in doubt about where to send your changes, please check first
with the PEP author and/or a PEP editor.

PEP authors with git push privileges for the PEP repository can update the
PEP authors with write access to the PEP repository can update the
PEPs themselves by using "git push" or the GitHub PR interface to submit their
changes.

Expand Down Expand Up @@ -677,7 +678,7 @@ PEP Editor Responsibilities & Workflow
A PEP editor must be added to the ``@python/pep-editors`` group on GitHub and
must watch the `PEP repository`_.

Note that developers with git push privileges for the `PEP repository`_ may
Note that developers with write access to the `PEP repository`_ may
handle the tasks that would normally be taken care of by the PEP editors.
Alternately, even developers may request assistance from PEP editors by
mentioning ``@python/pep-editors`` on GitHub.
Expand All @@ -696,8 +697,8 @@ For each new PEP that comes in an editor does the following:

* The file name extension is correct (i.e. ``.rst``).

* Make sure the appropriate core developer(s) is added to
`.github/CODEOWNERS` [7]_.
* Ensure that everyone listed as a sponsor or co-author of the PEP who has write
access to the `PEP repository`_ is added to `.github/CODEOWNERS` [7]_.

* Skim the PEP for obvious defects in language (spelling, grammar,
sentence structure, etc.), and code style (examples should conform to
Expand Down