Thanks to visit codestin.com
Credit goes to github.com

Skip to content

PEP 11: Clarify Windows support phases #2801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2022
Merged

PEP 11: Clarify Windows support phases #2801

merged 1 commit into from
Sep 24, 2022

Conversation

njsmith
Copy link
Contributor

@njsmith njsmith commented Sep 23, 2022

This isn't a semantic change, but I just got "extended support" and "extended security updates" confused and Steve Dower had to correct me. So make it even more obvious in the text that we mean "extended support", and not "extended security updates".

This isn't a semantic change, but I just got "extended support" and "extended security updates" confused and Steve Dower had to correct me. So make it even more obvious in the text that we mean "extended support", and not "extended security updates".
@njsmith njsmith requested a review from zooba September 23, 2022 11:19
@@ -158,13 +158,15 @@ Microsoft has established a policy called product support lifecycle
[1]_. Each product's lifecycle has a mainstream support phase, where
the product is generally commercially available, and an extended
support phase, where paid support is still available, and certain bug
fixes are released (in particular security fixes).
fixes are released. Sometimes this is then followed by a third phase
called "ESU", for "extended security updates".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps mention ESU is a program of last resort? And link to https://learn.microsoft.com/en-us/lifecycle/faq/extended-security-updates

Comment on lines +161 to +162
fixes are released. Sometimes this is then followed by a third phase
called "ESU", for "extended security updates".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would (and did, in python/cpython#76773 (comment) ) describe ESU not as a "phase" but rather a specialized, paid program for high-volume enterprise customers, and be more explicit here (as well as below) in mentioning ESU specifically in the context of making clear the distinction with the Extended Support phase and CPython support, rather than making it part of "this lifecycle" that CPython is stated to follow below.

So, how about (incorporating @hugovk 's comments as well):

Suggested change
fixes are released. Sometimes this is then followed by a third phase
called "ESU", for "extended security updates".
fixes are released. This is distinct from `ESU (Extended Security Updates)
<https://learn.microsoft.com/en-us/lifecycle/faq/extended-security-updates>`_,
a specialized, paid program available to high-volume enterprise customers
as a "last resort" option after the end of extended support.

Comment on lines +166 to +169
phase is not yet expired. (We don't consider the ESU phase for this
purpose; only the "extended support" phase.) Subsequent bug fix releases
will support the same Windows releases as the original feature release
(even if the extended support phase has ended).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
phase is not yet expired. (We don't consider the ESU phase for this
purpose; only the "extended support" phase.) Subsequent bug fix releases
will support the same Windows releases as the original feature release
(even if the extended support phase has ended).
phase is not yet expired. (ESU is not considered supported.)
Subsequent bug fix releases will support the same Windows releases
as the original feature release (even if the extended support phase has ended).

Following the above, clarifying that ESU is a specialized program, not a phase, and avoiding repeating ourselves about "extended support" too many times.

@njsmith
Copy link
Contributor Author

njsmith commented Sep 24, 2022

tbh I can't get too worked up over the precise meaning of "phase" or how we describe Microsoft's program for them, as long as the text makes it clear that for our purposes "extended support" = supported, "ESU" = not supported, and no-one has raised any concerns about that. So I'm just going to merge on the theory that it's at least better than what we have now, and then if y'all want to keep wordsmithing feel free :-).

@njsmith njsmith merged commit a3ada0e into main Sep 24, 2022
@njsmith njsmith deleted the njsmith-patch-1 branch September 24, 2022 17:12
CAM-Gerlach added a commit to CAM-Gerlach/peps that referenced this pull request Sep 24, 2022
@CAM-Gerlach
Copy link
Member

CAM-Gerlach commented Sep 24, 2022

Accordingly, I went ahead and opened PR #2802 to apply those fixes and improvements, and also took the opportunity to update and clarify the language and links describing Microsoft's lifecycle policies to reflect that Windows >=10 follows a different lifecycle from that previous described there (while deferring any substantive changes to CPython's own policy to a future discussion and decision).

CAM-Gerlach added a commit that referenced this pull request Oct 2, 2022
* PEP 11: Elide long-obselete emacs declaration & header fields
* PEP 11: Convert last footnote to inline link, fix redirect & use HTTPS
* PEP 11: Apply ESU textual fixes/improvements suggested on #2801
* PEP 11: Update Windows section to clarify Fixed vs. Modern lifecycle
* PEP 11: Apply reviewer-suggested tweaks

Co-authored-by: Steve Dower <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants