PEP 703: fix some typos #3298
Merged
PEP 703: fix some typos #3298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AA-Turner
reviewed
Aug 21, 2023
remilapeyre
commented
Aug 21, 2023
AA-Turner
reviewed
Aug 21, 2023
There was a problem hiding this comment.
To note, in general we discourage PRs to fix typos:
Most typos don't hamper readability much less than many other "defects" in our documentation, like poor wording, unclear examples, and outright ambiguities. We receive way fewer fixes for those quality issues.
I'll merge this though, given both are unambiguous.
A
|
I'm sorry, I did not know this, I thought it was ok to do since this PEP is still in draft. It may be nice to add a note about this at https://github.com/python/peps/blob/main/.github/PULL_REQUEST_TEMPLATE/Change%20an%20existing%20PEP.md
Best,
Rémi
De : Adam Turner ***@***.***>
Date : lundi, 21 août 2023 à 18:20
À : python/peps ***@***.***>
Cc : Rémi Lapeyre ***@***.***>, Author ***@***.***>
Objet : Re: [python/peps] PEP 703: fix some typos (PR #3298)
@AA-Turner commented on this pull request.
To note, in general we discourage PRs to fix typos<#2211 (comment)>:
Most typos don't hamper readability much less than many other "defects" in our documentation, like poor wording, unclear examples, and outright ambiguities. We receive way fewer fixes for those quality issues.
I'll merge this though, given both are unambiguous.
A
—
Reply to this email directly, view it on GitHub<#3298 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AIMSCUGRI3YPYPWUVADX7ATXWODFBANCNFSM6AAAAAA3YQRQJQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://pep-previews--3298.org.readthedocs.build/