Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Infra: Remove GNU make-specific directive from Makefile #3891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 4, 2024

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Aug 4, 2024

Like python/cpython#122662.

This is mostly to keep the Makefiles similar in each repo to ease maintenance.

Also promote the make check-links deprecation warning (added in November 2023 in #3514) to an error, although we could probably remove it already?


📚 Documentation preview 📚: https://pep-previews--3891.org.readthedocs.build/

@hugovk hugovk added the infra Core infrastructure for building and rendering PEPs label Aug 4, 2024
@hugovk hugovk requested a review from AA-Turner as a code owner August 4, 2024 14:41
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the claim for best-effort support for BSD make in CPython read across to PEPs? I'd be hesitant to make a guarantee.

Regardless this looks fine, and removing make check-links also seems fine.

A

@hugovk
Copy link
Member Author

hugovk commented Aug 4, 2024

Does the claim for best-effort support for BSD make in CPython read across to PEPs? I'd be hesitant to make a guarantee.

Agreed, I don't think it applies here.

Regardless this looks fine, and removing make check-links also seems fine.

Removed!

@AA-Turner AA-Turner merged commit de536ac into python:main Aug 4, 2024
6 checks passed
@hugovk hugovk deleted the rm-gnu-make branch August 4, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Core infrastructure for building and rendering PEPs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants