-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
PEP 750: restrict support for Template
+ str
addition
#4395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
davepeck
wants to merge
6
commits into
python:main
Choose a base branch
from
davepeck:pep750-template-add-update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+39
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the label to prevent inadvertent merging before pronouncement |
dvarrazzo
reviewed
May 20, 2025
I've updated this PR to match the steering council decision on template concatenation. /cc @AA-Turner |
This was referenced Jun 26, 2025
warsaw
approved these changes
Jun 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @davepeck ! LGTM, with one very minor grammatical suggestion.
Commit Barry’s suggestion Co-authored-by: Barry Warsaw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP 123: Summary of changes
)Following this PR opened with the steering-council and related discussion, we propose an update to PEP 750 that:
Template
/Template
concatenation (both implicit and explicit)Template
/str
concatenation (both implicit and explicit)A rationale is provided and the two relevant sections of the PEP are updated (
"Template String Concatenation"
and, in rejected ideas,"Disallowing Template Concatenation"
).📚 Documentation preview 📚: https://pep-previews--4395.org.readthedocs.build/