PEP 793: Two small updates #4472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- PyType_GetModuleByToken will return a strong reference, unlike PyType_GetModuleByDef - Remove incorrect note that the new API creates modules from a *spec*. (The note could be updated to say *slots*, but, it isn't that important.)
hugovk
approved these changes
Jun 24, 2025
|
Ugh, ignore the second change. I got confused by def vs. spec again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyType_GetModuleByTokenwill return a strong reference, unlikePyType_GetModuleByDefRemove incorrect note that the new API creates modules from a spec. (The note could be updated to say slots, but, it isn't that important.)PEP 123: Summary of changes)📚 Documentation preview 📚: https://pep-previews--4472.org.readthedocs.build/