-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
spam #4584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spam #4584
Conversation
Co-authored-by: Arcweld1 <[email protected]>
Co-authored-by: Arcweld1 <[email protected]>
The following commit authors need to sign the Contributor License Agreement: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a comprehensive CI/CD pipeline using GitHub Actions for a Python project. The workflow includes dependency installation, pre-commit validation, testing across multiple Python versions, and project building.
- Adds a complete GitHub Actions workflow with dependency management, testing, and building
- Implements multi-version Python testing (3.9-3.13) with fallback mechanisms
- Sets up pre-commit validation and build artifact generation with summary reporting
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
- name: Run tests with tox (using uvx) | ||
run: | | ||
uvx --with tox-uv tox -e py -- -v --cov-report term | ||
continue-on-error: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using continue-on-error: true
for the primary test execution masks test failures. Consider removing this and only using it for the fallback steps to ensure test failures are properly reported.
continue-on-error: true |
Copilot uses AI. Check for mistakes.
- name: Check spelling (manual hook) | ||
uses: tox-dev/action-pre-commit-uv@v1 | ||
with: | ||
extra_args: --all-files --hook-stage manual codespell || true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The || true
at the end of the codespell command will always make it succeed even if spelling errors are found. This defeats the purpose of spell checking in CI. Consider removing || true
or handling failures appropriately.
extra_args: --all-files --hook-stage manual codespell || true | |
extra_args: --all-files --hook-stage manual codespell |
Copilot uses AI. Check for mistakes.
Reported as spam to GH. |
π Documentation preview π: https://pep-previews--4584.org.readthedocs.build/