docs: Display a nice 404 when archives are not built yet. #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now that I've confirmed that the 404.html file exists I think this is 💯! Thanks Julien. And thanks @Mariatta that's a great idea to reduce noise from users. |
This was referenced Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on python/docsbuild-scripts#127
The idea is to avoid mails to docs@ telling the PDFs are 404ing.
We had "a lot" of them back then when we were building the PDF daily and the docs hourly. We have less now than we build the PDF at the same rate as the HTML (the html not pointing to an existing PDF lives for less time, but HTML is still build before PDF so users can still hit the 404).
It would allow to get back at the previous state where we were buildling the PDF less often, which would allow for faster HTML builds, for the joy of HTML readers (and the pain of PDF readers maybe).