Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Environment should inherit more #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gvanrossum opened this issue Mar 28, 2022 · 1 comment · Fixed by #172
Closed

Environment should inherit more #171

gvanrossum opened this issue Mar 28, 2022 · 1 comment · Fixed by #172

Comments

@gvanrossum
Copy link
Member

I just debugged (with @zooba's help) why building extensions like greenlet or psutil from source didn't work on Windows. We clean the environment too well, and two essential variables, "ProgramFiles" and "ProgramFiles(x86)", are erased, causing setuptools to fail finding the MSVC compiler. (Roughly here, though the error comes from here.)
@gvanrossum gvanrossum mentioned this issue Mar 28, 2022
Closed
gvanrossum added a commit that referenced this issue Mar 28, 2022
@gvanrossum
Inherit "ProgramFiles" in environment
9dc8cf1 
(and "ProgramFiles(x86)")
Fixes #171.
@gvanrossum gvanrossum mentioned this issue Mar 28, 2022
Merged
gvanrossum added a commit that referenced this issue Mar 29, 2022
@gvanrossum
Inherit "ProgramFiles" in environment (#172)
8f03712 
(and "ProgramFiles(x86)")
Fixes #171.
@ericsnowcurrently
Copy link
Member

Nice catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Inherit "ProgramFiles" in environment python/pyperformance
2 participants
@ericsnowcurrently @gvanrossum