Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add benchmark to measure gc collection of a big chain of cycles #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2022
Merged

Add benchmark to measure gc collection of a big chain of cycles #243

merged 1 commit into from
Nov 7, 2022

Conversation

pablogsal
Copy link
Member

No description provided.

@pablogsal
Copy link
Member Author

More to come, I will create a PR per benchmark

markshannon
markshannon reviewed Nov 7, 2022
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOI do you have any numbers as to what fraction of the runtime this spends in GC?

@pablogsal
Copy link
Member Author

pablogsal commented Nov 7, 2022 •
edited
Loading

OOI do you have any numbers as to what fraction of the runtime this spends in GC?

By definition all of it, as the benchmark is only measuring the gc.collect() call for the destruction of all the cycles.

ericsnowcurrently
ericsnowcurrently approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablogsal pablogsal merged commit 6d10e48 into python:main Nov 7, 2022
@pablogsal pablogsal deleted the gc1 branch November 7, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon markshannon left review comments

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@mdboom mdboom Awaiting requested review from mdboom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablogsal @ericsnowcurrently @markshannon