Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Traducción de library/uu.po #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 21, 2020
Merged

Traducción de library/uu.po #1146

merged 4 commits into from
Nov 21, 2020

Conversation

fzuccolo
Copy link
Contributor

Primera contribución. #796

eamanu
eamanu reviewed Nov 19, 2020
View reviewed changes
@eamanu
Copy link
Contributor

eamanu commented Nov 19, 2020

@fzuccolo Muchas gracias por tu primera contribución!

Te dejé unos comentarios, por si los quieres tomar y fijate que el build está fallando por el pospell

@fzuccolo
Copy link
Contributor Author

Gracias por la revisión! Corrí pospell localmente:

$ awk 1 dict dictionaries/*.txt > dict.txt
$ pospell -p dict.txt -l es_AR -l es_ES library/uu.po
library/uu.po:54:Ellinghouse
library/uu.po:54:Jack

y creé dictionaries/library_uu.txt, agregando los nombres que faltaban.

@fzuccolo
Copy link
Contributor Author

Gracias por las sugerencias, ya hice las correcciones.

@fzuccolo fzuccolo marked this pull request as ready for review November 19, 2020 14:26
eamanu
eamanu approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lo veo bien! \o/

@cmaureir cmaureir merged commit 28dac4c into python:3.8 Nov 21, 2020
@cmaureir
Copy link
Collaborator

Buenísimo @fzuccolo 🎉 muchas gracias !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clacri clacri clacri left review comments

@cmaureir cmaureir cmaureir approved these changes

@eamanu eamanu eamanu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fzuccolo @eamanu @cmaureir @clacri