fix dict_dups check #374
Merged
fix dict_dups check #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
a mi me gustaria ponerlo en pre-commit pero no tengo ni idea de como funciona, y de hecho me gustaria aprenderlo, asi que si lo haceis así, me encantaría participar! |
clacri
approved these changes
May 26, 2020
|
Voy haciendo el merge de esto ya que roto en Travis actualmente y le da problemas a las nuevas PRs. Luego vemos lo de pre-commit o si lo quitamos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix para el check de duplicados.
@humitos estaba proponiendo removerlo. Yo creo que nos agrega un mínimo chequeo de que alguien no agrega mil cosas random. Pero si les parece que no aporta lo sacamos.
Alguien sabe cómo agregar un comando bash en un pre-commit? podríamos moverlo ahí tal vez.
Si les parece mejor sacarlo avisen y lo hago en este PR