-
Notifications
You must be signed in to change notification settings - Fork 395
Traducido archivo library/selectors #989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hola, voy a revisar este. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hola @drawsoek, muchas gracias por el trabajo de traducción. Te dejo unos comentarios a ver que te parecen, la mayoría son convenciones y algunos errores a subsanar para ver si podemos hacer que pase el build.
Co-authored-by: fjsevilla <[email protected]>
Co-authored-by: fjsevilla <[email protected]>
Co-authored-by: fjsevilla <[email protected]>
Co-authored-by: fjsevilla <[email protected]>
Co-authored-by: fjsevilla <[email protected]>
Co-authored-by: fjsevilla <[email protected]>
Co-authored-by: fjsevilla <[email protected]>
Co-authored-by: fjsevilla <[email protected]>
Co-authored-by: fjsevilla <[email protected]>
Co-authored-by: fjsevilla <[email protected]>
Co-authored-by: fjsevilla <[email protected]>
Co-authored-by: fjsevilla <[email protected]>
Co-authored-by: fjsevilla <[email protected]>
Co-authored-by: fjsevilla <[email protected]>
Co-authored-by: fjsevilla <[email protected]>
Co-authored-by: fjsevilla <[email protected]>
Co-authored-by: fjsevilla <[email protected]>
Co-authored-by: fjsevilla <[email protected]>
Co-authored-by: fjsevilla <[email protected]>
Co-authored-by: fjsevilla <[email protected]>
Co-authored-by: fjsevilla <[email protected]>
Co-authored-by: fjsevilla <[email protected]>
Co-authored-by: fjsevilla <[email protected]>
Co-authored-by: fjsevilla <[email protected]>
Co-authored-by: fjsevilla <[email protected]>
Co-authored-by: fjsevilla <[email protected]>
Co-authored-by: fjsevilla <[email protected]>
Co-authored-by: fjsevilla <[email protected]>
Co-authored-by: fjsevilla <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hola @drawsoek, bueno, solo queda un pequeño error de esos que Travis (y yo antes) pasa por alto y a veces solo se ven en la documentación renderizada y el tema de pospell. Para lo primero te dejo una sugerencia, con powrap pasado para que no rompa el build, espero.
Para lo segundo, las palabras que pospell no reconoce son:
monitoriza
monitorizados
monitorizado
no tiene problema con "monitorizar" pero no le gusta conjugarlo, ni el participio, ni la primera persona del sing del presente, ... La RAE dice que está bien :), así que solo queda agregar un diccionario para el archivo con los tres términos y realizar un commit a esta PR.
Cualquier problema o duda avisa.
Co-authored-by: fjsevilla <[email protected]>
Se agrego diccionario |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
¡Perfecto! Ya pasa el build y por mi parte se puede mergear. Gracias por el rápido feedback y felicidades por la traducción Jonathan, uno menos que queda. 🎉🎉🎉
Muchas muchas gracias @drawsoek ! 💪 🎉 👯 🚀 |
Gracias @cmaureir y @fjsevilla-dev |
Closes #884