Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make merge of 3.9 #1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 11, 2020
Merged

Make merge of 3.9 #1385

merged 5 commits into from
Sep 11, 2020

Conversation

Seluj78
Copy link
Collaborator

@Seluj78 Seluj78 commented Aug 24, 2020

No description provided.

@Seluj78 Seluj78 added NEED REVIEWER This PR needs a reviewer :) meta labels Aug 24, 2020
@Seluj78 Seluj78 self-assigned this Aug 24, 2020
Seluj78
Seluj78 commented Aug 24, 2020
View reviewed changes
@Seluj78
Copy link
Collaborator Author

Seluj78 commented Aug 24, 2020

Need review vite fait before merge plz

@Seluj78 Seluj78 mentioned this pull request Aug 24, 2020
Closed
deronnax
deronnax reviewed Aug 24, 2020
View reviewed changes
library/ctypes.po
@@ -1960,6 +1960,16 @@ msgstr ""
"donc définir vous-même le bon attribut :attr:`restype` pour pouvoir les "
"utiliser."

#: library/ctypes.rst:None
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est normal ce header avec le numéro de ligne à None ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JulienPalard ?

@deronnax
Copy link
Collaborator

comment on peut review un diff de 10.000 lignes ? @JulienPalard c'est vraiment important de mettre à jour le header Creation-Date ? Osef non ? Au moins la moitié du diff c'est ça.

D'ailleurs, quasi tous les headers po sont inutiles maintenant avec git...

@christopheNan
Copy link
Contributor

comment on peut review un diff de 10.000 lignes ? @JulienPalard c'est vraiment important de mettre à jour le header Creation-Date ? Osef non ? Au moins la moitié du diff c'est ça.

D'ailleurs, quasi tous les headers po sont inutiles maintenant avec git...

Personnellement, je trouve ça utile. Après, tu peux personnaliser ton git-diff comme indiqué dans Contributing ou git diff -G '^"POT'.

@Seluj78
Copy link
Collaborator Author

Seluj78 commented Aug 26, 2020

Du coup, merge ?

christopheNan
christopheNan approved these changes Sep 5, 2020
View reviewed changes
Copy link
Contributor

@christopheNan christopheNan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Seluj78 Seluj78 merged commit 757ab3f into python:3.9 Sep 11, 2020
@Seluj78 Seluj78 deleted the 39-make-merge branch September 11, 2020 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deronnax deronnax deronnax left review comments

@christopheNan christopheNan christopheNan approved these changes

@JulienPalard JulienPalard Awaiting requested review from JulienPalard

@awecx awecx Awaiting requested review from awecx

Assignees

@Seluj78 Seluj78

Labels
meta NEED REVIEWER This PR needs a reviewer :)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Seluj78 @deronnax @christopheNan