Thanks to visit codestin.com
Credit goes to github.com

Skip to content

New release? #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hugovk opened this issue Mar 6, 2023 · 5 comments · Fixed by #110
Closed

New release? #109

hugovk opened this issue Mar 6, 2023 · 5 comments · Fixed by #110

Comments

@hugovk
Copy link
Member

hugovk commented Mar 6, 2023

The last release was https://github.com/python/python-docs-theme/releases/tag/2022.1 in January 2022.

There's been a few bug fixes merged since then:

Notably:

My main motivation for a release is the dark theme: #44

I think it's ready for merge and release, but if we want to be safe, I suggest we make one release with the bugfixes, followed by another with the dark theme. That gives us the option to easily rollback in case there are any big issues.

cc @JulienPalard and @Mariatta :)
@JulienPalard JulienPalard mentioned this issue Mar 7, 2023
Merged
@JulienPalard
Copy link
Member

JulienPalard commented Mar 10, 2023 •
edited
Loading

Tag pushed, build one, testing one last time by building cpython doc with it locally...

$ cd cpython/Doc
$ make venv
$ ./venv/bin/pip install ../../python-docs-theme/dist/python_docs_theme-2023.3-py3-none-any.whl 
$ make htmlview

Looks good to me, uploading to pypi.

@pradyunsg pradyunsg mentioned this issue Mar 10, 2023
Merged
10 tasks
@hugovk
Copy link
Member Author

hugovk commented Mar 13, 2023

Please could we have a new bugfix release with #113 to fix #108 (comment)?

It's causing docs build errors for 3.10 for example at python/cpython#102638.

@JulienPalard
Copy link
Member

Working on it!

@JulienPalard
Copy link
Member

@hugovk done.

@hugovk
Copy link
Member Author

hugovk commented Mar 13, 2023

I restarted https://github.com/python/cpython/actions/runs/4403319435 and it passed now.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Releasing v2023.3 python/python-docs-theme
2 participants
@JulienPalard @hugovk