Add PyUnstable_Object_IsUniquelyReferenced #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5020859 to
02628ac
Compare
vstinner
reviewed
Sep 1, 2025
tests/test_pythoncapi_compat_cext.c
Outdated
| @@ -1953,6 +1953,28 @@ test_unicodewriter_format(PyObject *Py_UNUSED(self), PyObject *Py_UNUSED(args)) | |||
| } | |||
| #endif | |||
|
|
|||
| #ifndef PYPY_VERSION | |||
There was a problem hiding this comment.
The function doesn't make sense on PyPy?
There was a problem hiding this comment.
Apparently not, maybe an interned string? I rewrote it to use an empty tuple and that seems to work on PyPy.
There was a problem hiding this comment.
I rewrote it to use an empty tuple and that seems to work on PyPy.
but that seems to have broken other builds, let me see if I can get it working everywhere...
|
Tests fail on Python 2: |
I guess empty tuples have had reference counting optimizations for a long time! |
|
Please update also the doc:
|
vstinner
reviewed
Sep 1, 2025
|
Merged, thanks for your contribution. I'm not very excited by adding |
This was referenced Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a shim for
PyUnstable_Object_IsUniquelyReferencedand a test for the shim.I'd like to use this function in a few libraries but don't want to have to have a thread-unsafe check in 3.13 or add new uses of internal headers outside of the compat header here.
I'm not sure whether the using stuff from internal headers is ok in a shim like this. I'm also not sure if you want to avoid
PyUnstablefunctions in the compat headers.The implementation is copy/pasted from the implementation of
_PyObject_IsUniquelyReferenced.