Test add_to_pydotorg.list_files
#258
Conversation
tests/ftp-file-list.txt
Outdated
| @@ -0,0 +1,587 @@ | |||
| Python-3.14.0a1.tar.xz | |||
There was a problem hiding this comment.
Can we possibly mark this file in some way as "test data only, doesn't need to be updated for each release"?
There was a problem hiding this comment.
Is its presence in the tests directory good enough, or is there a better file name?
Otherwise we can add a comment above its use in tests/test_add_to_pydotorg.py, and/or add a # comment at the top with add some handling to skip those lines?
There was a problem hiding this comment.
My first reaction when I saw the file contents was "oh no something else we have to update on each release" except it isn't, so it'd be nice to have something in the file itself to indicate that.
Maybe if we can work mock into the filename? Or fake? I'm not sure how the library works, but the code should ignore bad filenames anyway, so putting "NOT A REAL LIST, THIS DOESN'T NEED UPDATING" at the top shouldn't hurt anything. Bit ugly, but it could save someone a brief moment of stress.
There was a problem hiding this comment.
Oh, and a comment in the test itself is probably a bit far away. I'm thinking it's more likely someone will do a search for 3.14.0 and find the data, so won't necessarily look where it's being used.
There was a problem hiding this comment.
Sure, I've renamed the file to tests/fake-ftp-files.txt and put a comment at the top.
|
LGTM! |
Let's merge this before #255, it helps find a bug.