Remove LD_LIBRARY_PATH before running gdb (#13594)

srittau · web-flow · commit b4c656a6f7b0 · 2025-03-08T00:09:47.000+01:00
Suggestion by @peace-maker
diff --git a/stubs/gdb/METADATA.toml b/stubs/gdb/METADATA.toml
@@ -13,6 +13,3 @@ extra_description = """\
 [tool.stubtest]
 platforms = ["linux"]
 apt_dependencies = ["gdb"]
-# TODO (2025-03-05): unskip once `gdb` can be installed on `ubuntu-24.04`,
-# see https://github.com/python/typeshed/pull/13582
-skip = true
diff --git a/tests/stubtest_third_party.py b/tests/stubtest_third_party.py
@@ -252,6 +252,9 @@ def setup_gdb_stubtest_command(venv_dir: Path, stubtest_cmd: list[str]) -> bool:
         import sys
 
         stubtest_env = os.environ | {{"STUBTEST_ARGS": json.dumps(sys.argv)}}
+        # With LD_LIBRARY_PATH set, some GitHub action runners look in the wrong
+        # location for gdb, causing stubtest to fail.
+        stubtest_env.pop("LD_LIBRARY_PATH", None)
         gdb_cmd = [
             "gdb",
             "--quiet",
