Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[aiofiles] Use file mode alias from _typeshed #10233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented May 31, 2023

No description provided.

@srittau srittau marked this pull request as ready for review May 31, 2023 08:53
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@JelleZijlstra
Copy link
Member

This allows a lot more modes.

@srittau
Copy link
Collaborator Author

srittau commented May 31, 2023

Which should be ok, since the mode parameter is just passed on to open(). We could argue not to allow read-only modes, but those were allowed previously, and I wanted to avoid semantic changes for now.

@srittau
Copy link
Collaborator Author

srittau commented Jun 7, 2023

This is blocking two other PRs (#10232 and #10229), so it would be great if someone could have a look at it.

@JelleZijlstra JelleZijlstra merged commit 786bd22 into python:main Jun 7, 2023
@srittau srittau deleted the aiofiles-tempfile branch June 7, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants