Add is_cli param to pydoc.pyi #10331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
hauntsaninja
approved these changes
Jun 19, 2023
This comment has been minimized.
This comment has been minimized.
|
Now that Python 3.12b3 has made its way to GitHub Actions, the lack of this parameter is causing our CI to fail on For now, I'm going to edit this PR so that it just includes the parameter on py312+. We can change the stub so that the parameter is also included on py311 when we get a py311 release that includes the parameter :) |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As introduced in this PR,
pydoc.docandHelper.helpnow has anis_clikeyword parameter, which defaults toFalse.It's has been backported to 3.11 branch, so I added a check for the version.