Improve stubs for braintree.environment
#10907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
srittau
approved these changes
Oct 18, 2023
Comment on lines
12
to
13
| is_ssl: Any | ||
| ssl_certificate: Any |
There was a problem hiding this comment.
To get rid of the Anys (which should be Incompletes):
Suggested change
| is_ssl: Any | |
| ssl_certificate: Any | |
| is_ssl: bool | |
| ssl_certificate: bool | str | None |
ssl_certificate is passed to request's send() method, which takes bool | str | None as verify argument:
There was a problem hiding this comment.
Hmmm, just because it's passed to send() doesn't mean that bool | str | None is the correct type, though -- maybe it's always a str, in which case bool | str | None will cause false positives. For now, I think I'll just use Incomplete for ssl_certificate
| is_ssl: Any | ||
| ssl_certificate: Any | ||
| def __init__( | ||
| self, name, server, port, auth_url, is_ssl, ssl_certificate, graphql_server: str = "", graphql_port: str = "" | ||
| self, name, server: str, port, auth_url: str, is_ssl, ssl_certificate, graphql_server: str = "", graphql_port: str = "" |
There was a problem hiding this comment.
Suggested change
| self, name, server: str, port, auth_url: str, is_ssl, ssl_certificate, graphql_server: str = "", graphql_port: str = "" | |
| self, name, server: str, port, auth_url: str, is_ssl: bool, ssl_certificate: bool | str | None, graphql_server: str = "", graphql_port: str = "" |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10905