argparse: Use SupportsWrite instead of IO #13324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diff from mypy_primer, showing the effect of this PR on open source code: mypy (https://github.com/python/mypy)
+ mypy/main.py:375: error: Argument 1 of "print_usage" is incompatible with supertype "ArgumentParser"; supertype defines the argument type as "Optional[SupportsWrite[str]]" [override]
+ mypy/main.py:375: note: This violates the Liskov substitution principle
+ mypy/main.py:375: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides
+ mypy/main.py:380: error: Argument 1 of "print_help" is incompatible with supertype "ArgumentParser"; supertype defines the argument type as "Optional[SupportsWrite[str]]" [override]
+ mypy/main.py:380: note: This violates the Liskov substitution principle
+ mypy/main.py:380: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides
+ mypy/main.py:385: error: Argument 2 of "_print_message" is incompatible with supertype "ArgumentParser"; supertype defines the argument type as "Optional[SupportsWrite[str]]" [override]
+ mypy/main.py:385: note: This violates the Liskov substitution principle
+ mypy/main.py:385: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides
|
hamdanal
added a commit
to hamdanal/mypy
that referenced
this pull request
Dec 28, 2024
This is in anticipation of python/typeshed#13324
hauntsaninja
pushed a commit
to python/mypy
that referenced
this pull request
Dec 28, 2024
This is in anticipation of python/typeshed#13324
JelleZijlstra
approved these changes
Dec 30, 2024
hoel-bagard
pushed a commit
to hoel-bagard/typeshed
that referenced
this pull request
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.