Improve oauthlib.common
#13744
Merged
Improve oauthlib.common
#13744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
srittau
reviewed
Mar 31, 2025
This comment has been minimized.
This comment has been minimized.
srittau
requested changes
Mar 31, 2025
Collaborator
srittau
left a comment
There was a problem hiding this comment.
Thanks, comments below.
stubs/oauthlib/oauthlib/common.pyi
Outdated
| body: str | dict[str, str] | list[tuple[str, str]] | None | ||
| decoded_body: list[tuple[str, str]] | None | ||
| oauth_params: list[str] | ||
| validator_log: dict[str, Any] |
Contributor
Author
There was a problem hiding this comment.
I changed it to object, an example of defining value can be found for example in oauthlib.oauth1.rfc5849.endpoints.resource.ResourceEndpoint.validate_protected_resource_request
Contributor
Author
There was a problem hiding this comment.
oh I just thought that maybe someone would want to pass a result that could be None, should I add | None for value?
Collaborator
There was a problem hiding this comment.
object isn't correct, since it would mean that every key can have any object. A suitable comment could be as simple as "# value type depends on the key".
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Mar 31, 2025
mmingyu
pushed a commit
to mmingyu/typeshed
that referenced
this pull request
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.