Add new Python 3.14 argparse.ArgumentParser constructor parameters
#13947
+69
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are - `suggest_on_error`, added by python/cpython#124456, made keyword-only by python/cpython#133302 - `color`, added by python/cpython#132323
|
Our policy is generally to not add features for new Python versions until the first beta, but that's tomorrow so I think it's fine to get this in. |
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Comment on lines
+720
to
+721
| suggest_on_error: bool = ..., | ||
| color: bool = ..., |
There was a problem hiding this comment.
Suggested change
| suggest_on_error: bool = ..., | |
| color: bool = ..., | |
| suggest_on_error: bool = False, | |
| color: bool = False, |
I think we didn't fill in defaults here because at runtime they go through **kwargs. Let's add defaults for the new parameters at least, and if you like we can add defaults for the rest at some point too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are
suggest_on_error, added by GH-99749: Add optional feature to suggest correct names (ArgumentParser) cpython#124456, made keyword-only by gh-133300: argparse: makesuggest_on_errora keyword-only parameter cpython#133302color, added by gh-130645: Add colour toargparsehelp cpython#132323