networkx: add all missing __all__
#13956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
May 7, 2025
| @@ -23,3 +24,5 @@ from networkx.utils.misc import ( | |||
| from networkx.utils.random_sequence import * | |||
| from networkx.utils.rcm import * | |||
| from networkx.utils.union_find import * | |||
|
|
|||
| config: NetworkXConfig # Set by networkx/__init__.py | |||
There was a problem hiding this comment.
This is the only "special thing" I had to do throughout this PR.
networkx/__init__.py contains the lines:
config = utils.backends._set_configs_from_environment()
utils.config = utils.configs.config = config
This comment has been minimized.
This comment has been minimized.
| @@ -1,7 +1,15 @@ | |||
| from binascii import Incomplete | |||
There was a problem hiding this comment.
binascii? I think this recurs a few times
There was a problem hiding this comment.
ugh, bad Pylance autoimport I didn't notice. Thanks for catching it !
JelleZijlstra
approved these changes
May 9, 2025
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst merging stubs from https://github.com/microsoft/python-type-stubs/tree/main/stubs/networkx , I noticed a lot of missing functions. Let's start with
__all__.I set
ignore_missing_stub = falseand went through all errors mentionning__all__.Not that I didn't put any effort into new annotations further than what Pylance was able to provide for return types.
The point is to keep this a fairly simple and easy review. Which will reduce the complexity of upcoming PRs.