3.14: PEP-784 compression except zstd #13992
Open
+59
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
27b8b34 to
06181bc
Compare
This comment has been minimized.
This comment has been minimized.
06181bc to
e728c53
Compare
This comment has been minimized.
This comment has been minimized.
562bf17 to
24dafa3
Compare
This comment has been minimized.
This comment has been minimized.
|
There's a (small) merge conflict now due to allowlist changes. One request: Please don't force push here as that makes reviewing harder. We squash on merge anyway. |
|
Conflict should be resolved now. Sorry for the force-pushes earlier, I thought it was ok while the PR had the draft status. |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR about PEP-784 in sdlib:
bz2/gzip/lzma/zlibincompression.*_compressionintocompression._common._streams, and re-export the latter from the formerstubtest_allowlistsfor 3.14 accordingly (the additions are copied that already exists in the non-compressionmodules)For the last point, I did not find a better way than copying the file, because only one of the two modules exist depending on Python version (so cannot import from the other)▶️ feel free to suggest a better idea! (or tell if I should add a comment about that somewhere)
Adding
compression.zstdwill be done in a distinct PR.