Back out get_origin() parameter type #13999
Conversation
This comment has been minimized.
This comment has been minimized.
|
Somehow this doesn't change the mypy-primer hits back, but they did change in #13998. Not sure if mypy has nondeterministic behavior or we hit a bug in mypy-primer. |
This comment has been minimized.
This comment has been minimized.
|
I wonder if the new |
0b00f6f to
ad02b0d
Compare
This comment has been minimized.
This comment has been minimized.
|
We could add |
This comment has been minimized.
This comment has been minimized.
|
No effect from mypy primer so this version isn't right. Creating a type alias in |
Ok, in that case we should go with your initial idea of using |
|
Diff from mypy_primer, showing the effect of this PR on open source code: ibis (https://github.com/ibis-project/ibis)
- ibis/expr/operations/udf.py:143: error: Dict entry 0 has incompatible type "str": "Int64"; expected "str": "Argument" [dict-item]
artigraph (https://github.com/artigraph/artigraph)
- src/arti/types/python.py:145: error: Non-overlapping identity check (left operand type: "ParamSpec", right operand type: "<typing special form>") [comparison-overlap]
- src/arti/types/python.py:167: error: Non-overlapping identity check (left operand type: "ParamSpec", right operand type: "<typing special form>") [comparison-overlap]
hydra-zen (https://github.com/mit-ll-responsible-ai/hydra-zen)
- src/hydra_zen/_utils/coerce.py:111: error: Need type annotation for "list_caster_by_pos" (hint: "list_caster_by_pos: dict[<type>, <type>] = ...") [var-annotated]
- src/hydra_zen/_utils/coerce.py:112: error: Need type annotation for "list_caster_by_name" (hint: "list_caster_by_name: dict[<type>, <type>] = ...") [var-annotated]
- src/hydra_zen/_utils/coerce.py:149: error: Incompatible types in assignment (expression has type "type", variable has type "ParamSpec") [assignment]
koda-validate (https://github.com/keithasaurus/koda-validate)
- koda_validate/typehints.py:135: error: Non-overlapping identity check (left operand type: "ParamSpec", right operand type: "type[Just[A]]") [comparison-overlap]
|
From #13985