builtins: remove object.__annotations__
#14000
Draft
+8
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all objects have annotations, so I think this shouldn't exist. We already have `__annotations__` attributes explicitly set on the objects that do have them (e.g., functions, classes, and modules).
This comment has been minimized.
This comment has been minimized.
|
This seems promising, we'll just have to add |
|
The openlibrary change is a true positive, at least on 3.14 where accessing Not sure about the steam.py one; it seems to be using annotations in an odd way. cc @Gobot1234 The other three should go away with the changes I'm about to push. |
|
In steam.py I'm using it for data parsing I don't think my use case is crazy out of the ordinary but I can stomach adding |
|
You might need to use |
|
CI breakage seems due to a release of click 20 minutes ago https://pypi.org/project/click/8.2.0/ |
|
Diff from mypy_primer, showing the effect of this PR on open source code: steam.py (https://github.com/Gobot1234/steam.py)
- steam/protobufs/struct_messages.py:24: error: Incompatible types in assignment (expression has type "tuple[()]", variable has type "dict[str, Any]") [assignment]
+ steam/protobufs/struct_messages.py:22: error: "StructMessage" has no attribute "__annotations__" [attr-defined]
+ steam/protobufs/struct_messages.py:29: error: "StructMessage" has no attribute "__annotations__" [attr-defined]
- steam/ext/csgo/backpack.py:291: error: Definition of "SLOTS" in base class "DescriptionMixin" is incompatible with definition in base class "BaseItem" [misc]
openlibrary (https://github.com/internetarchive/openlibrary)
+ openlibrary/plugins/upstream/table_of_contents.py: note: In member "extra_fields" of class "TocEntry":
+ openlibrary/plugins/upstream/table_of_contents.py:85: error: "TocEntry" has no attribute "__annotations__" [attr-defined]
+ openlibrary/plugins/upstream/table_of_contents.py: note: In member "is_empty" of class "TocEntry":
+ openlibrary/plugins/upstream/table_of_contents.py:174: error: "TocEntry" has no attribute "__annotations__" [attr-defined]
hydra-zen (https://github.com/mit-ll-responsible-ai/hydra-zen)
+ src/hydra_zen/third_party/pydantic.py:53: error: "_Wrapped[[VarArg(Any), KwArg(Any)], Any, [VarArg(Any), KwArg(Any)], Any]" has no attribute "__annotations__" [attr-defined]
zulip (https://github.com/zulip/zulip)
+ corporate/lib/decorator.py:144: error: "_Wrapped[[HttpRequest, RemoteRealmBillingSession, **ParamT], HttpResponse, [HttpRequest, **ParamT], HttpResponse]" has no attribute "__annotations__" [attr-defined]
+ corporate/lib/decorator.py:231: error: "_Wrapped[[HttpRequest, RemoteServerBillingSession, **ParamT], HttpResponse, [HttpRequest, **ParamT], HttpResponse]" has no attribute "__annotations__" [attr-defined]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all objects have annotations, so I think this shouldn't exist.
We already have
__annotations__attributes explicitly set on theobjects that do have them (e.g., functions, classes, and modules).
Not sure what the fallout of this is going to be; it might not be worth changing.