Update functools for 3.14 #14002
Merged
Update functools for 3.14 #14002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-muoto
commented
May 11, 2025
| @@ -269,6 +262,9 @@ types.UnionType.__mro_entries__ | |||
| types.UnionType.__name__ | |||
| types.UnionType.__qualname__ | |||
|
|
|||
| # Assigning `__new__` causes `func` not to get recognized. | |||
There was a problem hiding this comment.
Seeing issues here, __new__ hasn't changed but is being assigned to a function instead of being assigned inline causing issues with stub-test.
There was a problem hiding this comment.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
JelleZijlstra
approved these changes
May 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make updates required for
functoolsin 3.14functools.reducemaking it soinitialdoesn't have to be positional.__annotations__->__annotate__inWRAPPER_ASSIGNMENTSandupdate_wrapperFinals.functools.Placeholder