Update pathlib for 3.14 #14006
Merged
Update pathlib for 3.14 #14006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
max-muoto
commented
May 11, 2025
stdlib/pathlib/__init__.pyi
Outdated
| on_error: Callable[[OSError], object] | None = None, | ||
| ) -> None: ... | ||
| @property | ||
| def info(self) -> _PathInfo: ... |
There was a problem hiding this comment.
The technical accurate type would be pathlib._os._WindowsPathInfo | pathlib._os._PosixPathInfo | pathlib._os.DirEntryInfo but considering they all implement the exact same methods (and live in a private module) defining a type-checking only type made more sense to me. Open to changing this however.
This comment has been minimized.
This comment has been minimized.
srittau
requested changes
May 11, 2025
Thanks, comments addressed! |
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
May 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
pathlibupdates for 3.14.pathlib.Pathmethods, accounting for the fact that iftarget_typeis a non PurePath thenSelfis returned otherwise the type oftarget_typeis returned.pathlib.typesmodule andPathInfoprotocol.