Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Replace incomplete module markers #14030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented May 12, 2025

Closes: #13765

@srittau
Copy link
Collaborator Author

srittau commented May 12, 2025

For reference, #9548 removed the mentions of incomplete modules from CONTRIBUTING. Since the advent of stubgen, I don't expect many new instances to show up.

Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau marked this pull request as ready for review May 12, 2025 18:16
@srittau srittau requested a review from Avasam May 12, 2025 18:16
Copy link
Collaborator

@Avasam Avasam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the # incomplete module comment instead of just # incomplete

It's also nice to see only a few changes in pyrightconfig.stricter.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Returning Unknown instead of Any for incomplete __getattr__
2 participants