Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update typing-extensions to 4.14.0rc1 #14139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 25, 2025
Merged

Update typing-extensions to 4.14.0rc1 #14139

merged 14 commits into from
May 25, 2025

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented May 25, 2025

No description provided.

srittau
srittau commented May 25, 2025
View reviewed changes
srittau
srittau commented May 25, 2025
View reviewed changes
@srittau srittau linked an issue May 25, 2025 that may be closed by this pull request
Daily tests failed on Sun May 25 2025 #14133
Closed
JelleZijlstra
JelleZijlstra reviewed May 25, 2025
View reviewed changes
AlexWaygood
AlexWaygood reviewed May 25, 2025
View reviewed changes
JelleZijlstra
JelleZijlstra reviewed May 25, 2025
View reviewed changes
@srittau
Copy link
Collaborator Author

srittau commented May 25, 2025

Um, pre-commit makes "interesting" (and clearly wrong) things in c3df9f6.

AlexWaygood
AlexWaygood reviewed May 25, 2025
View reviewed changes
@JelleZijlstra
Copy link
Member

pre-commit makes "interesting" (and clearly wrong) things

It probably doesn't recognize typing_extensions.TypeAlias as marking a type alias. You probably need # noqa: PYI015 (https://docs.astral.sh/ruff/rules/assignment-default-in-stub/)

@AlexWaygood
Copy link
Member

pre-commit makes "interesting" (and clearly wrong) things

It probably doesn't recognize typing_extensions.TypeAlias as marking a type alias. You probably need # noqa: PYI015 (docs.astral.sh/ruff/rules/assignment-default-in-stub)

I think the reason it failed to recognize TypeAlias as being TypeAlias here is because we're actually editing typing_extensions.pyi itself. If we'd imported it from typing_extensions (or typing), it would have recognized it, I think.

@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood merged commit 07c09a4 into python:main May 25, 2025
101 checks passed
@srittau srittau deleted the fix-extensions branch May 25, 2025 16:10
@Viicos Viicos mentioned this pull request May 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Daily tests failed on Sun May 25 2025
3 participants
@srittau @JelleZijlstra @AlexWaygood