Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update default values for ast.ImportFrom initialization #14308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Update default values for ast.ImportFrom initialization #14308

wants to merge 7 commits into from

Conversation

hunterhogan
Copy link
Contributor

@hunterhogan hunterhogan commented Jun 19, 2025 •
edited
Loading

Addresses #14338

Details

Illustration of ast.ImportFrom.level default value

(.313) C:\clones\typeshed>py
Python 3.13.5 (tags/v3.13.5:6cb20a2, Jun 11 2025, 16:15:46) [MSC v.1943 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import ast
>>> yum = ast.ImportFrom('popeyes', [ast.alias('chicken')])
>>> ast.unparse(yum)
'from popeyes import chicken'
>>> print(yum.level)
None

donBarbos
donBarbos reviewed Jun 19, 2025
View reviewed changes
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@hunterhogan @donBarbos
Update stdlib/ast.pyi
a03345c 
Co-authored-by: Semyon Moroz <[email protected]>
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@hunterhogan

This comment was marked as duplicate.

Sign in to view
@hunterhogan
Refactor ImportFrom class to adjust level type based on Python ve…
4b1aa7f 
…rsion and enhance constructor overloads for better compatibility
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@hunterhogan

This comment was marked as resolved.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@hunterhogan

This comment was marked as resolved.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@hunterhogan hunterhogan mentioned this pull request Jun 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donBarbos donBarbos donBarbos left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hunterhogan @donBarbos