ast: Remove 3 TypeAlias. Fix identifier collision.
#14319
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
stdlib/ast.pyi
Outdated
| class match_case(AST): | ||
| __match_args__ = ("pattern", "guard", "body") | ||
| pattern: _Pattern | ||
| pattern: pattern |
There was a problem hiding this comment.
This is incorrect (even if type checkers currently allow it). The name pattern in the class namespace should refer to the pattern attribute, not the pattern class. Using ast.pattern might work.
There was a problem hiding this comment.
I thought it was odd that the type checkers didn't complain about these annotations, but I didn't change it because I was trying to change as little as possible.
Meta: I am not sure I am using this part of the GitHub tool correctly. The options say things like "View reviewed changes", then Review changes but there are no changes and VS Code wants me to Start Review of the thing I am viewing or make a code suggestion. One screen said "Buffalo buffalo Buffalo buffalo buffalo buffalo Buffalo buffalo."
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Fix #14280