Remove _field_types from abstract classes: this is not a feature. Per @terryjreedy See https://github.com/python/cpython/issues/135797#issuecomment-2993817570 #14320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Comment on lines
+47
to
+49
| if sys.version_info >= (3, 13): | ||
| _field_types: ClassVar[dict[str, Any]] | ||
|
|
There was a problem hiding this comment.
Instead of repeating this in every concrete class, it might make sense to move this to a protocol that these classes all inherit from. Something like
@type_check_only
class _ConcreteNode(Protocol):
if sys.version_info >= (3, 13):
_field_types: ClassVar[dict[str, Any]]That would reduce the chance of something getting out of sync if anything changes about _field_types in the future
There was a problem hiding this comment.
I agree 1 billion percent with not duplicating the code. I don't know how to do it, however. If I were to try to edit the file, I would give your code snippet to AI assistants and ask them to explain to me how to incorporate it. 🫤
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.